(Using Drone Self-Hosted via docker image)
Steps to reproduce
Expected behavior:
Hey there, I am unable to reproduce this issue, nor are we receiving reports of issue at cloud.drone.io of authentication issue.
edit: if you open a private browser window, you will no longer be authenticated (since the cookie that authenticates the user would not be available in private mode). So this sounds like the expected behavior.
I tried it again…
Going unauthenticated to Drone 2.0
In Chrome DevTools, console logs the following
GET https://drone.fgf.cloud/api/user/builds/recent 401
GET https:// drone.fgf.cloud/api/user 401
GET https:// drone.fgf.cloud/api/user/repos?latest=true 401
GET https:// drone.fgf.cloud/api/repos/WWW/focus 401
401 replies to unauthenticated calls look as designed
However, the UI shows a 404 page.
2.0 has a splash page prior to authentication.
(Which we still hit by going straight to the drone base url)
On 401s, I’d expect the user to be redirected there.
(Also, on that splash page, there are still calls made for user/builds that are answered with 401…
Let’s make sure we’re not creating a redirect loop…)
2.0 has a splash page prior to authentication.
(Which we still hit by going straight to the drone base url)On 401s, I’d expect the user to be redirected there.
(Also, on that splash page, there are still calls made for user/builds that are answered with 401…
Let’s make sure we’re not creating a redirect loop…)
Drone exhibits the same behavior as GitHub where it displays a Not Found page if the repository is private and you are not logged-in. When you directly visit a private repository in Drone 1.x it displays a “sql no rows in result set” error, and similar to Drone 2.x, does not automatically redirect.
Perhaps one area of improvement would be to make the Login button more visible. You currently have to click the avatar in the bottom left corner of the page which is not very intuitive.
Drone exhibits the same behavior as GitHub where it displays a Not Found page if the repository is private and you are not logged-in. When you directly visit a private repository in Drone 1.x it displays a “sql no rows in result set” error, and similar to Drone 2.x, does not automatically redirect.
Ok, I see where you’re going there.
In a workflow where pipelines can be public, that makes total sense.
I configured Drone close to a year ago, and it’s been working for me ever since.
I might have forgotten a few configuration options that were available.
I’ll gladly take to telling my users to ensure they’re logged in when they report 404s, if that’s the tradeoff to have my instance fully authenticated.
Perhaps one area of improvement would be to make the Login button more visible. You currently have to click the avatar in the bottom left corner of the page which is not very intuitive.
That might be an idea, I did not notice there was a user button there prior to you mentioning it.
However, I’ll leave that one up to you, as I’m most definitely not a UI/UX designer
Thanks for the quick follow up!
