Restarting a promoted build loses target environment

JeffDownie · July 1, 2019, 10:40am

When I try to restart a build that has been run as the result of a promotion, drone seems to trigger a new promotion build, but with the variable set to empty - for example, if I run

drone build promote my/repository 123 production

It works fine, but when I hit the restart button in the UI for this build, it does something roughly the equivalent of

drone build promote my/repository 123

(after the 123 intentionally left blank)

Does anyone know if this intentional behaviour?

bradrydzewski · July 1, 2019, 3:49pm

good catch, looks like the Deployment field is not being copied to the hook. Also looks like customer parameters are not being copied.

github.com

drone/drone/blob/master/handler/api/repos/builds/retry.go#L66




		switch prev.Status {
		case core.StatusBlocked:
			render.BadRequestf(w, "cannot start a blocked build")
			return
		case core.StatusDeclined:
			render.BadRequestf(w, "cannot start a declined build")
			return
		}


		hook := &core.Hook{
			Trigger:      user.Login,
			Event:        prev.Event,
			Action:       prev.Action,
			Link:         prev.Link,
			Timestamp:    prev.Timestamp,
			Title:        prev.Title,
			Message:      prev.Message,
			Before:       prev.Before,
			After:        prev.After,
			Ref:          prev.Ref,

genisd · July 2, 2019, 9:45am

We’re suffering from this too
Another detail is that promotion builds report to github as “pr check builds”, so github marks the deployment itself as abandoned after some time.

random · March 31, 2020, 4:07am

Same issue. Any plans to fix it ?

ashwilliams1 · March 31, 2020, 4:19am

This issue was fixed a few months ago, see fa8e17dc3764d58bdef575f8bb8c97a3a90c6add